fix inconsistent behavior with BrushContainer + minor bug #1091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inconsistent behavior is a discrepancy in how the brush container handles redrawing the brush depending on the value of the allowResize prop if defaultArea is set to 'disable'
Here's a quick demo: https://codesandbox.io/s/4jvl663pkw
This PR makes two changes, both small:
I didn't add unit tests since there didn't seem to be any around the events for the brush helper. I feel bad submitting a PR without unit tests - I'm happy to add some if y'all have guidance on a preferred approach to testing this.