Pie Label Positioning #1130
Merged
Pie Label Positioning #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the option for "startAngle" and "endAngle" for the label to be positioned. The default is "centroid" which does not altere the original behavior. As posted on the issue FormidableLabs#1117 it would be nice to position the label inside the actual slice but as per one rule of no-magic-numbers I can't multiply by 0.9 to do this equally for all labels. This could be left for later. Closes FormidableLabs#1117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option for "startAngle" and "endAngle" for the label to be
positioned.
The default is "centroid" which does not altere the original behavior.
As posted on the issue #1117 it would be nice to position the label
inside the actual slice but as per one rule of no-magic-numbers I can't
multiply by 0.9 to do this equally for all labels. This could be left
for later.
Closes #1117