Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated barWidth to evaluate width function with datum and active props. #1152

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Updated barWidth to evaluate width function with datum and active props. #1152

merged 1 commit into from
Oct 24, 2018

Conversation

bmwe30is
Copy link
Contributor

The barWidth function was not originally evaluating a function being passed in.

Updated the getBarWidth function to evaluate the barWidth function to evaluate the function passed in with datum and active props.

@bmwe30is bmwe30is force-pushed the jc-bar-width-fix branch 2 times, most recently from c719a1b to 42f2525 Compare October 20, 2018 20:31
@boygirl
Copy link
Contributor

boygirl commented Oct 24, 2018

@bmwe30is thanks for this fix! Could you please run nps lint and be sure our linting rules are passing?

@bmwe30is
Copy link
Contributor Author

Yes, absolutely!

@boygirl
Copy link
Contributor

boygirl commented Oct 24, 2018

Thanks!

@boygirl boygirl merged commit eab00c8 into FormidableLabs:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmwe30is @boygirl