TS migrate: victory-scatter

[sblinde]

Description

This PR migrates the victory-scatter package to TypeScript!

[gksander]

Looks good!

One thing I wanted to point out is the use of !, the non-null assertion operator. This TS operator basically says, "I'm telling you, the compiler, that I know this value isn't undefined or null". It's basically a way of telling TS to shut up a bit. For test files, which is where you have it used here, this isn't really a big deal. In application code, I always advise against this operator – as it waters down the usefulness of TS! It's generally better to do an actual check like if (svg) { .... than to do svg!.foo....

No changes needed here, test files it's fine to tell TS to be quiet, just wanted to point this out as a nugget for when you go on to (hopefully) use TS in client projects!

[sblinde]

Looks good!

One thing I wanted to point out is the use of !, the non-null assertion operator. This TS operator basically says, "I'm telling you, the compiler, that I know this value isn't undefined or null". It's basically a way of telling TS to shut up a bit. For test files, which is where you have it used here, this isn't really a big deal. In application code, I always advise against this operator – as it waters down the usefulness of TS! It's generally better to do an actual check like if (svg) { .... than to do svg!.foo....

No changes needed here, test files it's fine to tell TS to be quiet, just wanted to point this out as a nugget for when you go on to (hopefully) use TS in client projects!

Thank you! Super helpful info!