Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Date equality in axis #2642

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

scottarver
Copy link
Contributor

fixes #2251

Dates can't be compared with ===

new Date().getTime()
1693254943567
new Date(1693254943567) === new Date(1693254943567)
false
new Date(1693254943567).getTime() === new Date(1693254943567).getTime()
true

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 6:45pm

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2023

🦋 Changeset detected

Latest commit: 107e9e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-axis Patch
victory Patch
victory-area Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-core Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-native Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-vendor Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@carbonrobot
Copy link
Contributor

@scottarver Do you mind pushing an empty commit so I can approve the Ci run?

@carbonrobot
Copy link
Contributor

Looks like the CI run is failing on a missing semicolon on line 265. You can run cd packages/victory-axis && pnpm run format to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation 'right' not working with dates
2 participants