Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc getting started fixes #2775

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Misc getting started fixes #2775

merged 5 commits into from
Feb 5, 2024

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Feb 2, 2024

Background

To familiarize myself with the project, I went through the tutorial. Noted a few issues which I'm fixing in this PR.

They are:

  • Slight verbiage changes
  • Fixed anchor links for headings with numbers in them (i.e. 3. Add Victory).

Changes:

  • update renderHeading to strip leading numbers and periods, so that a syntactically accurate id element would be created (i.e. id="add-victory" instead of id="3-add-victory")

Copy link

changeset-bot bot commented Feb 2, 2024

⚠️ No Changeset found

Latest commit: 7910a23

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 6:13pm

@Burnett2k Burnett2k marked this pull request as ready for review February 2, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants