Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Named OSS Badge Exports #2963

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bryantkelley
Copy link
Member

@bryantkelley bryantkelley commented Nov 12, 2024

Description

Update OSS Badges package and use named badge exports to reduce file sizes

Fixes # (issue)

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran website locally to verify new badges render correctly.

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Nov 12, 2024

⚠️ No Changeset found

Latest commit: f28fb8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 14, 2024 6:24pm

@bryantkelley bryantkelley self-assigned this Nov 12, 2024
Copy link
Contributor

Folder/File Previous size New size Difference
/packages/victory/dist/victory.min.js 385.54KB 387.85KB +2.3KB (+0.60%)
TOTAL +2.3KB

Copy link
Contributor

@carbonrobot carbonrobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like all icons are still imported into the production bundles. We may need to add sideEffects: false to the oss lander package to help Webpack tree shake this properly.

image

You should be able to test this locally by using pnpm link between the two projects instead of having to release a new package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants