Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Disable arbitrary styles from data
This change deprecates Victory's ability to automatically pick up style attributes from the data object. This change will improve performance, but will be a breaking change for many users. Fortunately the upgrade path is simple:
If your data object looks like
Add the following functional styles:
and everything will work as before.
Limit Pre-calculating label props
Base props for labels will no longer be pre-calculated unless a labels prop exists. This change improves performance, but it will be a breaking change for users who were using events for adding labels to elements that did not already have them using an event mutation like:
If you are using this pattern, you can make labels work as expected by adding a dummy labels prop like:
labels={() => null}
Note: This change does not affect tooltips, which exist, but are invisible until they receive the
active
propAll Changes
VictoryCore
-364 Perf: Remove style whitelist filter.
-369 Ensure state
-368 Audit lodash methods
-367 Simplify state filtering
-365 Perf: Return early when label content is null or undefined
-362 Perf: Filter falsey mutations from state
VictoryChart
-587 Disable styles on data
-584 Check for labels prop before computing baseProps for labels
-589 Audit lodash methods
-583 Perf improvement for
VictorySelectionContainer
VictoryPie
-176 Disable styles on data
-177 Audit lodash methods