Skip to content

Commit

Permalink
Bug: (#338)
Browse files Browse the repository at this point in the history
- Bug: Allow socket message to be null. Fixes #335, fixes #336.
  • Loading branch information
ryan-roemer authored Sep 6, 2021
1 parent 1c958c4 commit ee73086
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# Changelog

This project adheres to [Semantic Versioning](http://semver.org/).
Every release, along with the migration instructions, is documented on the Github [Releases](https://github.com/FormidableLabs/webpack-dashboard/releases) page.

## UNRELEASED

- Bug: Allow socket messages to be null. [#335](https://github.com/FormidableLabs/webpack-dashboard/issues/335), [#336](https://github.com/FormidableLabs/webpack-dashboard/issues/336)

## [3.3.5] - 2021-07-12

Expand Down
4 changes: 3 additions & 1 deletion bin/webpack-dashboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ const main = opts => {
});

socket.on("message", (message, ack) => {
if (message.type !== "log") {
// Note: `message` may be null.
// https://github.com/FormidableLabs/webpack-dashboard/issues/335
if (message && message.type !== "log") {
dashboard.setData(message, ack);
}
});
Expand Down

0 comments on commit ee73086

Please sign in to comment.