Address security warnings, upgrade dependencies, use npm-run-all
.
#283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was inspired a bit by #282, which incentivized me to see if we had any other security vulnerabilities. It turns out we did 😬Running
yarn audit
onmaster
currently outputs the following:After taking a look at the security warnings on
npm
, it became clear we could avoid these just by bumping a few of our dependencies. Runningyarn audit
on this branch yields no security warnings.I also decided to make two other changes in this PR:
text
as our command line coverage reporter fornyc
. This gives us nice reporting on lines missing coverage and matches the Jest UI (which I find helpful when strategizing about what to test).npm-run-all
for ourcheck
andcheck-ci
scripts. I likenpm-run-all
because it will detect what client you're using (npm
oryarn
) and use it for you to execute the scripts. I considered enforcingyarn
here but realized this is often a polarizing enough decision that it might turn off contributors. For example, contributors can stillnpm install
the project if they really want to, but if we usedyarn
in all of thesepackage.json
scripts, they flat out wouldn't work fornpm
users.npm-run-all
is a nice in-between that keeps everyone happy. It exposesrun-s
which will run the commands in sequence (it also exposesrun-p
which will do things in parallel).