Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change Kurt from an interface to an abstract class #13

Merged
merged 1 commit into from
May 8, 2024
Merged

refactor: change Kurt from an interface to an abstract class #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/kurt-open-ai/src/KurtOpenAI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { zodToJsonSchema } from "zod-to-json-schema"
import { KurtStream } from "@formula-monks/kurt"
import { Kurt, KurtStream } from "@formula-monks/kurt"
import type {
Kurt,
KurtCreateOptions,
KurtGenerateNaturalLanguageOptions,
KurtGenerateStructuredDataOptions,
Expand Down Expand Up @@ -37,8 +36,10 @@ export type KurtOpenAICreateOptions = KurtCreateOptions & {
openAI: OpenAI
}

export class KurtOpenAI implements Kurt {
constructor(private options: KurtOpenAICreateOptions) {}
export class KurtOpenAI extends Kurt {
constructor(private options: KurtOpenAICreateOptions) {
super()
}

generateNaturalLanguage(
options: KurtGenerateNaturalLanguageOptions
Expand Down
9 changes: 5 additions & 4 deletions packages/kurt-vertex-ai/src/KurtVertexAI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import "./VertexAI.patch.generateContentStream" // monkey-patches VertexAI GenerativeModel.prototype.generateContentStream

import zodToJsonSchema from "zod-to-json-schema"
import { KurtStream } from "@formula-monks/kurt"
import { Kurt, KurtStream } from "@formula-monks/kurt"
import type {
Kurt,
KurtCreateOptions,
KurtGenerateNaturalLanguageOptions,
KurtGenerateStructuredDataOptions,
Expand Down Expand Up @@ -37,8 +36,10 @@ export type KurtVertexAICreateOptions = KurtCreateOptions & {
vertexAI: VertexAI
}

export class KurtVertexAI implements Kurt {
constructor(private options: KurtVertexAICreateOptions) {}
export class KurtVertexAI extends Kurt {
constructor(private options: KurtVertexAICreateOptions) {
super()
}

generateNaturalLanguage(
options: KurtGenerateNaturalLanguageOptions
Expand Down
8 changes: 4 additions & 4 deletions packages/kurt/src/Kurt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ import type {
KurtSchemaResult,
} from "./KurtSchema"

export interface Kurt {
generateNaturalLanguage(
export abstract class Kurt {
abstract generateNaturalLanguage(
options: KurtGenerateNaturalLanguageOptions
): KurtStream

generateStructuredData<I extends KurtSchemaInner>(
abstract generateStructuredData<I extends KurtSchemaInner>(
options: KurtGenerateStructuredDataOptions<I>
): KurtStream<KurtSchemaResult<I>>

generateWithOptionalTools<I extends KurtSchemaInnerMap>(
abstract generateWithOptionalTools<I extends KurtSchemaInnerMap>(
options: KurtGenerateWithOptionalToolsOptions<I>
): KurtStream<KurtSchemaMapSingleResult<I> | undefined>
}
Expand Down
Loading