Font Awesome Documention descibes ability to pass parameters to the d… #15639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om.watch() function yet when attemping this the paramereters are not defined in the interface.
|
Hi! Thanks for being part of the Font Awesome Community and thanks for this PR. Let's assign @robmadole and @mlwilkerson |
This was referenced Sep 2, 2022
|
in my pull request #19301 I've made both parameters optional. Don't know if this is allowed to pass only one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font Awesome document states that the dom.watch() interface allows for parameters to be passed to limit the scope of the watch yes these paramereters are not defined in the interface.
https://fontawesome.com/how-to-use/with-the-api/methods/dom-watch
I understand that:
I understand that it will not be merged and I will not be listed as a contributor on this project.