Allow pause in MUTATION_OBSERVER with config.observeMutations #15859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isn't ready and runs to an out of memory error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.observeMutationsis only checked before the MUTATION_OBSERVER is created, but I need this check at runtime when the DOM is too busy. The disable function isn't exposed to an interface. unwatch() is also not available. This was the simplest change.This change allows the DOM.watch() to be paused in cases that could cause an out of memory error.
Issue link:
#15858
I understand that:
I understand that it will not be merged and I will not be listed as a contributor on this project.