Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage for decorated class properties #17326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix usage for decorated class properties #17326

wants to merge 1 commit into from

Commits on Oct 28, 2020

  1. Fix usage for decorated class properties 

    Given the following `tsconfig.json`:

```json
{
  "compilerOptions": {
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true
  }
}
```

The following will currently causes an import error:

```ts
import { IconName } from '@fortawesome/fontawesome-common-types';

class MyClass {
  @MyDecorator
  icon: IconName;
}
```

This is because in some situations TypeScript doesn’t know that `IconName` is a
only exists as a type. It will generate an import, which can’t be resolved.

Simply adding an empty JavaScript file, will make the environment able to import
the package, even though the import value of `IconName` will be `undefined`.
    @remcohaszing
    remcohaszing committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    b1f7b53 View commit details
    Browse the repository at this point in the history