Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License header is missing in free-solid-svg-icons@6.6.0/index.mjs #20368 #20378

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from

Conversation

yadavshubham01
Copy link

@yadavshubham01 yadavshubham01 commented Oct 9, 2024

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

This PR addresses the issue of missing license text in the index.mjs file for the @fortawesome/free-solid-svg-icons package, as outlined in issue #20368

How I solve this Issue:
Updated index.mjs: Added the necessary license comments to ensure proper attribution, complying with MIT and CC BY licenses.
Modified Rollup Configuration: Ensured that the build process retains the license comments without using Terser for minification, preserving the license visibility in the output.
Tested Build Process: Successfully built the project to confirm that the license text is now included in the final output.

@yadavshubham01
Copy link
Author

please review this PR @tagliala @robmadole

@tagliala
Copy link
Member

tagliala commented Oct 9, 2024

Hi @yadavshubham01, thanks for this PR and your willing to help

As mentioned in the contributing guidelines, this PR can't be merged and I'm not even confident that this approach will work in the upstream repository, because the code you are seeing here is being generated

Let's see how @robmadole wants to address this issue with new .mjs files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants