Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass: List var of all icons #6020

Closed
wants to merge 1 commit into from
Closed

Sass: List var of all icons #6020

wants to merge 1 commit into from

Conversation

CupOfTea696
Copy link

Adds a list variable of all icons to easily loop through

Adds a list variable of all icons to easily loop through
@zakmac zakmac mentioned this pull request Jun 30, 2015
@ketan
Copy link

ketan commented Aug 28, 2015

+1 - it would be great to see this change, so that font awesome is more usable with sass mixin frameworks.

I'm happy to rebase and submit a new PR if the maintainers are OK with this change, OR have a better idea to refactor the variables file so it's easier to "lookup" icons.

@XiBOR
Copy link

XiBOR commented Feb 11, 2016

+1

@drmonkeyninja
Copy link

This seems like a really good idea as it would surely make the Sass not only more usable but also easier to maintain as adding new icons would be as simple as adding a new icon to the list. Is there any chance of this being revisited and actually accepted into the master branch?

@PonchoPowers
Copy link

Can you change the title from SASS to Sass. See:
#8170

@CupOfTea696 CupOfTea696 changed the title SASS: List var of all icons Sass: List var of all icons Jun 22, 2017
@robmadole
Copy link
Member

First off, thanks for spending the time to post this PR. It's sat in the Font Awesome GitHub repo for far too long and we should have responded or addressed the work that you put into this.

Over the past year we've been hard at work on Font Awesome 5. It's now released and this PR no longer applies. So we're going to close it (with an apology for being so tardy).

If you think the work from this still applies feel free to reply and we'll take a second look.

– FA team

@robmadole robmadole closed this Jan 31, 2018
@CupOfTea696 CupOfTea696 mentioned this pull request Feb 9, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants