-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fa-stack renders blank, but removing wrapper renders icons #177
Comments
Somehow I've expected this issue to come up... Let's keep this issue open to implement a check for missing |
@devoto13 Ah. That's not so obvious from the documentation, I would have assumed default to have been '1x'. Either an error if it's missing or a default of '1x' would be useful, rather than rendering nothing. |
@plinkpaste Sorry about that. Can you submit a PR to mention in the documentation that the PS Unfortunately we can't make this a default, because it is a separate directive, which adds extra logic for the icon component and therefore needs to be added explicitly. |
@devoto13 Sure, I can do that. |
Previously we would silently drop elements without stackItemSize, which was confusing to users. With this change we also stop making assumptions about the passed elements to prevent issues like FortAwesome#283, but in fa-stack. Fixes FortAwesome#177
I want to display an icon stack on my page, so this is what I have:
However, this renders completely empty:
If I remove the
<fa-stack>
wrapper, the icons render:My implementation as I understand it is completely in-line with the documentation provided, so is this a bug or am I doing something wrong?
I'm running on Angular 8.2.3.
Font Awesome versions:
The text was updated successfully, but these errors were encountered: