Fix module packaging #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like Angular metadata resolver does not process them properly and resolves symbols to undefined if they are coming from re-export. I don't completely understand how it works, but after debugging this I also checked https://github.com/angular/angular/tree/master/packages and https://github.com/ng-bootstrap/ng-bootstrap/tree/master/src and none seem to have index.ts files besides the main one.
If @component is present compiler attempts to handle this class as a real component and fails because it was not added to the NgModule. What is really needed is to force metadata collection on this class and it can be achieved by putting some useless Angular decorator. angular/angular#16566 (comment)
|
Oh, yeah! 😄 I have also checked the tree-shaking with imports from main. Well, they actually "just work". The only problem is that they work about 4-5 times slower on production builds (~20s to 80-90s). I think we can solve this by using sideEffects free modules from Webpack 4, so Webpack will do the heavy lifting instead of Uglify, but I'll need to look deeper into this topic. Maybe over the weekend :) |
|
Wow, thanks for untangling these knots, @devoto13. |
|
Thank you so much @devoto13! |
mlwilkerson
pushed a commit
that referenced
this pull request
Mar 28, 2018
* Removed index.ts files from library It looks like Angular metadata resolver does not process them properly and resolves symbols to undefined if they are coming from re-export. I don't completely understand how it works, but after debugging this I also checked https://github.com/angular/angular/tree/master/packages and https://github.com/ng-bootstrap/ng-bootstrap/tree/master/src and none seem to have index.ts files besides the main one. * Replaced @component annotation with @Injectable() on the abstract class If @component is present compiler attempts to handle this class as a real component and fails because it was not added to the NgModule. What is really needed is to force metadata collection on this class and it can be achieved by putting some useless Angular decorator. angular/angular#16566 (comment)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, packaging of Angular library is not straight-forward >.<
Finally got it working with both JiT and AoT. Check commits for more detailed explanations.
And it definitely worths to add integration tests to prevent regressions in the future.