Allow to set a custom output file for the assets

[robclancy]

Font awesome is more than half our vendor right now and retroactively going over every icon used (lots in dynamic ways) to allow them in the build config would take a long time and be error prone (although we will have to do it oneday).
This means any dependency change for deployment causes us to download all of font awesome because it will no longer be cached. Our short term solution to this is to use a separate vendor js so that it will stay in the cache far longer, and even if we want we can disable fingerprints on it.

So my request is to allow to set the outputFile option in app.import, which we have hardcoded here. master...postedin:output-file

I can make a PR with it as an option isntead of hardcoding. In dev it all works just with a separate file loading in.

[jrjohnson]

Thanks @robclancy, I took a quick look, this seems like a very cool approach for dealing with caching the more static icon files.

I think I'd like to see this to be opt-in initially as I'm not sure if it would be breaking in some specific cases (Fastboot, yarn workspace, nested addons) it usually takes a while for those bugs to show up so opt-in gives more time to test for them in the wild.

I haven't ever seen that argument to app.import used - it's probably fine, but maybe do this work in treeForPublic instead?

[robclancy]

I mean I'd just want this as an option that defaulted to off.

…

On Fri., 15 May 2020, 01:19 Jonathan Johnson, ***@***.***> wrote: Thanks @robclancy <https://github.com/robclancy>, I took a quick look, this seems like a very cool approach for dealing with caching the more static icon files. I think I'd like to see this to be opt-in initially as I'm not sure if it would be breaking in some specific cases (Fastboot, yarn workspace, nested addons) it usually takes a while for those bugs to show up so opt-in gives more time to test for them in the wild. I haven't ever seen that argument to app.import used - it's probably fine, but maybe do this work in treeForPublic instead? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#146 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRIFZ4H4CHFEVRMNBRWR3RRTGEHANCNFSM4NBHE2KA> .