Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of getWithDefault() #155

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

bendemboski
Copy link
Contributor

Fixes #147

Copy link
Collaborator

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@jrjohnson jrjohnson merged commit a047298 into FortAwesome:master Jul 17, 2020
@bendemboski
Copy link
Contributor Author

You bet! Any notion of when this will be released? Debating running against my branch vs. installing ember-deprecation-workflow (which I haven't had to do thus far) to stop my builds from running out of memory from all the deprecation warnings in testem's in-memory log 😆

@jrjohnson
Copy link
Collaborator

I'd install deprecation workflow because it is awesome! But if I think we'll get this released very soon. I'd like to get #153 into a release as well and I have some bandwidth so I'm playing with that now.

@nadnoslen
Copy link
Contributor

Hey @jrjohnson,

Is there anything I can do to help get this released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation getWithDefault
3 participants