Docs for better Next.js integration #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenmed
approved these changes
Nov 8, 2019
haf
reviewed
Nov 8, 2019
README.md
Outdated
| export default MyApp | ||
| ``` | ||
|
|
||
| You may also wish to include you library calls in the `_app.js` code. |
haf
reviewed
Nov 8, 2019
| import { faBars, faUser } from '@fortawesome/free-solid-svg-icons' | ||
| import { faTwitter, faFacebook } from '@fortawesome/free-brands-svg-icons' | ||
|
|
||
| library.add(faBars, faUser, faTwitter, faFacebook) |
There was a problem hiding this comment.
I added a section below this to mention explicit import.
There was a problem hiding this comment.
I mean; I tried both in a nextjs project and there seems to be no upside to doing library.add at all?
|
Alright, thanks for the 👀 . Going to merge and we'll follow-up with more changes if needed. |
Vadorequest
reviewed
Nov 11, 2019
| @@ -26,6 +26,8 @@ | |||
| * [Basic](#basic) | |||
| * [Advanced](#advanced) | |||
| * [TypeScript](#typescript) | |||
| - [Integrating with other tools and frameworks](#integrating-with-other-tools-and-frameworks) | |||
| * [ext.js](#extjs) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.