Make possible to use size in percentage #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. It is actually works (I can specify size in percentage for react-native-svg component), but emits warning. This PR removes that warning and allows to specify icon size in percentage
|
@Strate can you speak more about why you needed percentage? This has me scratching my head a bit. I'm not against percentage but I'd like to understand it first. |
|
@robmadole I would also really benefit from this! For example, I have a grid of icons that scale with the device size (i.e. each icon is 1/4 of the device width) and ideally being able to set the icons to automatically adopt that width instead of being limited to a specific number would make that much easier to accomplish. This is likely fairly common with mobile devices, where many slightly different screen sizes could affect this functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
It is actually works (I can specify size in percentage for react-native-svg component), but emits warning. This PR removes that warning and allows to specify icon size in percentage