Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 5: enhanced block editing and self-hosting #224

Open
wants to merge 347 commits into
base: main
Choose a base branch
from
Open

Version 5: enhanced block editing and self-hosting #224

wants to merge 347 commits into from

Conversation

mlwilkerson
Copy link
Member

@mlwilkerson mlwilkerson commented Aug 2, 2024 •
edited
Loading

closes #220
closes #212

Original PR: #223 (renamed branch)

TODO:

  • investigate styling behavior in the block editor with WordPress 6.6
  • remove SRI hashes on svg-with-js.css
  • ensure svg styles are always fetched for self-hosting when needed
  • resolve "Uncaught ReferenceError: __ is not defined" when using Site Editor to insert icon
  • Test site editor with both recent WP and pre 6.3, due to using enqueue_block_editor_assets before 6.3 in font-awesome-icon-block-init.php

mlwilkerson and others added 30 commits July 16, 2024 17:27
@mlwilkerson
renaming classes
4f9aa82
@mlwilkerson
rebuild block-editor bundle
89a4452
@mlwilkerson
change the toolbar icon
c79717c
@mlwilkerson
clean up rich text icon and class naming
a65c673
@mlwilkerson
tweak the mutation observer to be constrained by the new rich text class
8cc40de
@mlwilkerson
rebuild block-editor bundle
1e49537
@mlwilkerson
add SCRIPT_DEBUG to debugging config
20982c8
@mlwilkerson
fix alignment of object replacement chars and replacement formats
469d357 
when adding multiple rich text icons within a single rich text value,
we have to make sure that replacement formats cover every character index
for the replacement, including the additional zero-width space character
we add.
@mlwilkerson
rebuild block-editor bundle
6dcd011
@mlwilkerson
inital cuts to remove layer and mask support for now
cb50d24
@mlwilkerson
remove onKeyDown event handling from toolbar button
56ceed3
@mlwilkerson
more cleanup
b75206a
@mlwilkerson
update renderIcon to parameterize the wrapperElement
e637fab
@mlwilkerson
refactoring transformation of icon chooser select event into iconDefi…
1f1fb37 
…nition
@mlwilkerson
use react component to render rich text icon as well to be DRY
0150ed2
@mlwilkerson
clean up old SVG rendering
2e60ca7
@mlwilkerson
remove the mutation observer: no longer needed
71aeffb 
apparently, we don't need it any more after switching rendering implemenations.

much cleaner and less hacky without it.
@mlwilkerson
fix rich text icon popover anchor
96dd2cc
@mlwilkerson
rebuild block-editor bundle
ac580f0
@frrrances
Start of icon styling UI (#222)
28dba72
@mlwilkerson
rebuild block-editor bundle
c81c4eb
@mlwilkerson
WIP: wiring up richTextIcon to use the IconModifier UI
ad191ce
@mlwilkerson
refactoring
0cae4d9
@mlwilkerson
handle rich text icon replacement
c4788a3
@mlwilkerson
preserve styling when changing rich text icon
bf7d12a
@mlwilkerson
render nothing when no iconLayers are present
cec1310
@mlwilkerson
handle power transforms for rich text icons
7961ff6
@mlwilkerson
only pick valid transform props
dcf4ec6
@mlwilkerson
use DOMParser instead of setting innerHTML
47933db
@mlwilkerson
remove a lot more layer and mask settings stuff
9661a0c
mlwilkerson and others added 30 commits August 9, 2024 17:31
@mlwilkerson
remove unused var
b691390
@mlwilkerson
rebuild admin bundle
c9ae274
@mlwilkerson
Release 5.0.0-alpha2
37dd568 
fix zip bundle
@mlwilkerson
Merge remote-tracking branch 'origin/master' into epic/v5
f8af49b
@mlwilkerson
do not add crossorigin or integrity to <link> when self-hosting
a09b701
@mlwilkerson
Merge branch 'master' into epic/v5
388e2e5
@mlwilkerson
always fetch svg-with-js.css when saving options and always load from…
9c24e9c 
… self-hosting
@mlwilkerson
move skip_enqueue_kit() into the main module
f414f91
@mlwilkerson
disable loader tests in CI
bd4af26
@mlwilkerson
rebuild icon-chooser bundle using local build
24250b8
@mlwilkerson
use enqueue_block_assets in more recent versions of WordPress
1a91303
@mlwilkerson
add missing import of __ from i18n
4d45905
@mlwilkerson
rebuild block-editor bundle
30058e2
@mlwilkerson
add override for SVG embed
90c0f95
@mlwilkerson
rebuild icon-chooser bundle
3c37564
@mlwilkerson
remove function type syntax that breaks for older PHP
0adb1e7
@mlwilkerson
fix mountAdminView to be compatible with React < 18
e3eeb7e
@mlwilkerson
rebuild admin bundle
2840f2f
@frrrances @mlwilkerson
Update WordPress plugin page readme and screenshots (#232)
2e2ca2a 
* update WordPress plugin page readme and screenshots

* resize screenshots

* revise readme for more technical aspects

---------

Co-authored-by: Mike Wilkerson <11575183+mlwilkerson@users.noreply.github.com>
@mlwilkerson
update to use fa-icon-chooser-react 0.8.0 production release
6ce882b
@mlwilkerson
rebuild icon-chooser bundle
e128804
@mlwilkerson
auto-formatting [skip ci]
78c3e76
@mlwilkerson
bump axios dep
0be075a
@mlwilkerson
update @WordPress scoped packages to use wp-6.7
80ed2d7 
This resolves some of the GitHub dependabot security alerts
@mlwilkerson
rebuild admin JS bundle
66ea427
@mlwilkerson
update block-editor bundle to use wp-6.7 deps
7fadfca
@mlwilkerson
update icon-chooser deps to use wp-6.7 dev deps
7232d88
@mlwilkerson
update classic-editor bundle to use wp-6.7 dev deps
3e6d503
@mlwilkerson
bump version 5.0.0-alpha3 [skip ci]
9ba9b4c
@mlwilkerson
revise readme.txt [skip ci]
676750a 
remove some of the details that will move over the docs.fontawesome.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP deprecation for md5() Icons as blocks
2 participants
@mlwilkerson @frrrances