Filter empty preprocessor flags; don't treat arithmetic gotos as function references #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to avoid asking the preprocessor to define a macro consisting of an empty string: 'cpp -D file' defines the macro "file" and processes standard input, for example.
An arithmetic goto like "go to (1) 1" could look like a reference to the function "to" when matching against CALL_RE. Although "go to" is in the intrinsics list, that space means that, unlike "goto", only "to" is being considered.
iainbarrass
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to avoid asking the preprocessor to define a macro consisting of
an empty string: 'cpp -D file' defines the macro "file" and processes
standard input, for example.
We also consider the problem of arithmetic GOTOs (#207).