calls to variables within a type no longer get added to call graph

[JosephWood2001]

With the addition of adding type calls to the call graph, a new problem arose from the caller of the type call sometimes not being able to find the procedure of the call due to it not existing in the context of the caller, but rather in the context of the type. Similarly, 'calls' that are just arrays aren't getting removed from the call graph because the variable doesn't exist in the context of the caller, but rather of the type, so it isn't detected as a variable.

To fix this, the chain of calls that leads to a call is now packaged with the information of the call. Then, when the calling procedure tries to find the procedure of the call, it will first traverse through the call chain to find the context/type that the call is made on, then from there, it can be checked if the call is not a call, but a variable of the type.

[ZedThree]

Thanks again @JosephWood2001 for another PR, it is genuinely appreciated!

This looks good, I just have a few suggestions to tidy up the code. sourceform is probably the most complex part of ford, so it's worth pulling out parts into their own standalone functions. This way, the main code becomes easier to read and understand, and we also get to test those individual parts more thoroughly and easily than having them all inline.

If you could also add a few tests to demonstrate the functionality you've added, that would also be very much appreciated!

[ZedThree]

Thanks again @JosephWood2001 for another PR, it is genuinely appreciated!

This looks good, I just have a few suggestions to tidy up the code. sourceform is probably the most complex part of ford, so it's worth pulling out parts into their own standalone functions. This way, the main code becomes easier to read and understand, and we also get to test those individual parts more thoroughly and easily than having them all inline.

If you could also add a few tests to demonstrate the functionality you've added, that would also be very much appreciated!

[JosephWood2001]

👍
Ah, I see there are some bracket matching functions in utils, unfortunately I couldn't get either of them to work for my purposes, so I created a new util function adjacent to them. The parsing is now pulled out into a function, and utilizing the new util function, the logic on how it gets to the answer is completely changed (and should be more readable)

The code to traverse the call chain has also been pulled out into it's own function. I also restructured it to no longer use the try except structure that it did in the last commit because I think there was way to much nesting and had a confusing execution flow.

All of your suggestions are appreciated and have been applied.

[ZedThree]

Awesome, thanks again @JosephWood2001 !