Add procedure binding calls to call graph #524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for call graphs to properly pick up on more complex bindings calls by comparing the calls to the bindings of a type rather then procedures that are in the type's context. This allows for bindings that may rename a proc to be properly recognized (i.e. procedure :: new_name => original_proc_name).
Some bindings are generic bindings that map one name onto multiple procs. To handle this, bindings can now be nodes themselves in the call graphs. At the moment, I made their color the same as interfaces, and calls made from them with dotted lines.
Here is a basic example:
'Simple' bindings that are just one label pointing to one proc are skipped over in the call graph, as I though it cluttered up the graph and was redundant.
This solves issue #516