Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default preprocessor to pcpp #570

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Switch default preprocessor to pcpp #570

merged 1 commit into from
Oct 13, 2023

Conversation

ZedThree
Copy link
Member

As this is a python package, we can install it by default, and so don't need to rely on cpp being installed on the host system

Fixes #567

@bkmgit I tried your podman file locally with this change and it seems to work, but maybe you want to double check it too?

As this is a python package, we can install it by default, and so
don't need to rely on `cpp` being installed on the host system
@bkmgit
Copy link

bkmgit commented Oct 13, 2023

Will check. pcpp has a bundled and slightly modified version of ply. It seems that ply will no longer be updated on pypi.

@bkmgit
Copy link

bkmgit commented Oct 13, 2023

Added GFortran to the build environment in Fedora, which enables all tests to run and pass - https://github.com/bkmgit/ford/tree/fedora-ci . It
would be helpful to have that information in the README file rather than hidden in the documentation. There may also be cases where people use flang or lfotran. As such would make pcpp an optional dependency.

GitHub
Automatically generates FORtran Documentation from comments within the code. - GitHub - bkmgit/ford at fedora-ci

@ZedThree
Copy link
Member Author

I'm not sure that the bundled ply is an issue. This PR also means we don't need to worry about any compilers being available in the build environment. Seeing as the docs may be built on an entirely different system, I think that's a good idea. If users want to switch to flang or lfortran for the preprocessor, that would have to be set manually anyway.

@ZedThree ZedThree merged commit a6a5478 into master Oct 13, 2023
10 checks passed
@ZedThree ZedThree deleted the switch-preprocessor branch October 13, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failures on Fedora linux
2 participants