Improve performance with large solutions #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the delay. will look at shortly |
tonyhallett
reviewed
Oct 13, 2022
SharedProject/Impl/CoverageColour/MarginBase/CoverageLineTaggerBase.cs
Outdated
Show resolved
Hide resolved
tonyhallett
reviewed
Oct 25, 2022
tonyhallett
reviewed
Oct 25, 2022
| .ToArray(); | ||
| } | ||
| private IEnumerable<Engine.Cobertura.Line> GetApplicableLines(string filePath, int startLineNumber, int endLineNumber) | ||
| => coverageLines.GetLines(filePath, startLineNumber, endLineNumber).ToArray(); |
| { | ||
| if (!m_coverageLines.TryGetValue(filename, out var classCoverageLines)) | ||
| { | ||
| classCoverageLines = new List<Line>(); |
There was a problem hiding this comment.
change variable name to fileCoverageLines
…tracted LowerBound extension method
|
released v1.1.187 and available on marketplace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a dictionary map from file name to lines to avoid searching through the entire coverage database for every file.
Improves VS responsiveness with large solutions