-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve breadcrumbs #48
base: master
Are you sure you want to change the base?
Conversation
It also fixes FossifyOrg/General-Discussion#73. |
I'll check this soon. From the screenshot, the 'Internal' part doesn't look like a button anymore, it should look like a button because it is the only way (to be revisited) to switch between "Internal", "SD Card", and other available storage volumes. |
It looks somewhat odd as a button, also the behavior is different to all other elements of the crumb, where tapping the element redirects to the corresponding folder. |
@connyduck can you restore the outline on the first button until we have a better way to navigate between storage volumes? |
This pull request has been automatically closed due to inactivity. We requested additional information but have not received a response from the original author. Without the requested details, we cannot proceed. If you have the needed information or updates, please reopen the PR or comment so we can continue the review. |
Stupid bot, I was still going to work on this |
# Conflicts: # commons/src/main/kotlin/org/fossify/commons/views/Breadcrumbs.kt
The breadcrumbs have several problems,
This PR solves all these problems and additionally improves the design by getting rid of the outline of the first item and using an actual icon instead of >.
What is it?
Before/After Screenshots
Fixes the following issue(s)
Fixes FossifyOrg/Gallery#208