Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve breadcrumbs #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

connyduck
Copy link
Contributor

@connyduck connyduck commented May 1, 2024

The breadcrumbs have several problems,

  • the background color and the actived state are wrongly set
  • on long paths the texts overlap
  • the code is more complicated than necessary

This PR solves all these problems and additionally improves the design by getting rid of the outline of the first item and using an actual icon instead of >.

What is it?

  • Bugfix
  • Feature
  • Codebase improvement

Before/After Screenshots

Fixes the following issue(s)

Fixes FossifyOrg/Gallery#208

@Aga-C
Copy link
Member

Aga-C commented May 1, 2024

It also fixes FossifyOrg/General-Discussion#73.

@naveensingh
Copy link
Member

naveensingh commented May 1, 2024

I'll check this soon.

From the screenshot, the 'Internal' part doesn't look like a button anymore, it should look like a button because it is the only way (to be revisited) to switch between "Internal", "SD Card", and other available storage volumes.

@KOTRET
Copy link

KOTRET commented May 3, 2024

It looks somewhat odd as a button, also the behavior is different to all other elements of the crumb, where tapping the element redirects to the corresponding folder.
In case there is no second drive, it should act as all other parts. Maybe it is possible to find a different indicator for this duo-action element.

@naveensingh
Copy link
Member

@connyduck can you restore the outline on the first button until we have a better way to navigate between storage volumes?

@naveensingh naveensingh added the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Nov 4, 2024
@fossifybot
Copy link

This pull request has been automatically closed due to inactivity. We requested additional information but have not received a response from the original author. Without the requested details, we cannot proceed. If you have the needed information or updates, please reopen the PR or comment so we can continue the review.

@fossifybot fossifybot closed this Nov 19, 2024
@connyduck
Copy link
Contributor Author

Stupid bot, I was still going to work on this

@naveensingh naveensingh reopened this Nov 19, 2024
@naveensingh naveensingh removed the waiting for author If the author does not respond, the issue will be closed. Otherwise, the label will be removed. label Nov 19, 2024
# Conflicts:
#	commons/src/main/kotlin/org/fossify/commons/views/Breadcrumbs.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Material You] "Select a folder" dialog - directory info row uses wrong color
5 participants