Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Bug ] "Password protect the whole application" option is not respected when photos/videos are opened by another app. #126

Closed
7 tasks done
onegladius opened this issue Feb 10, 2024 · 2 comments
Assignees
Labels
bug Something is not working

Comments

@onegladius
Copy link

onegladius commented Feb 10, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.1.1

Affected Android/Custom ROM version

Android 10

Affected device model

Motorola moto e7 Power

How did you install the app?

GitHub releases

Steps to reproduce the bug

  1. Open the Fossify Gallery app.
  2. Click on the 3 dots on the top right.
  3. Click on "Settings".
  4. Scroll down to "SECURITY" and enable "Password protect the whole application".
  5. Exit the gallery app.
  6. Open a photo viewing app that does NOT have a built in gallery ( e.g. Simple Camera, Fossify File Manager )
  7. Click on a picture

Expected behavior

It should ask for the PIN code in order for the photos/videos taken to be seen, and if not entered correctly further access should not be allowed.

Actual behavior

It directly opens the folder's contents, and the "ENTER PIN" overlay is only shown when trying to delete a photo/video ( if "Password protect file deletion and moving" is enabled ).

Screenshots/Screen recordings

Here is a video where I show the bug using the Camera app. It also happens when using the file manager, or basically any app that does not have a built in gallery and depends on the default gallery app.

2024-02-10_09-53-53.mp4

Additional information

• If the "Password protect file deletion and moving" option is enabled, it will be respected.

• I have tested with both Gallery apps ( Fossify and SMT latest release ) and both have the same issue.

@onegladius onegladius added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Feb 10, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Feb 10, 2024
@the-netspider
Copy link

Yes Its a must needed feature... At least while opening via cross app, opening settings menu must be restricted.!!
Thanks

naveensingh added a commit to FossifyOrg/Commons that referenced this issue Sep 15, 2024
 - Added a full screen activity for unlocking app
 - Added app lock manager for managing global lock state
 - Added new FossifyApp base application class that apps must subclass.

This will help remedy issues like FossifyOrg/Gallery#126
@naveensingh naveensingh self-assigned this Sep 15, 2024
@naveensingh
Copy link
Member

Should be fixed in the next update. The unlock UI will now be displayed in full screen:

Notes:

  • App will be locked instantly on back press.

  • App will be locked after 30 seconds when closed using any other gesture or method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

4 participants