-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video playback speed control #222
Video playback speed control #222
Conversation
It's counterintuitive. How somebody will know that it's done this way? Also, there's no visual guidance - I don't know when I can start moving my finger to change the speed. I think it should rather be done similarly as it's in Fossify Music Player (and similar to numerous other players like NewPipe or VLC), where we have an icon/button to change the playback speed, and it shows a normal slider.
Why this range? I doubt anybody will need speed higher than 3x. In Fossify Music Player we have range between 0.25x to 3x without limiting to multiplies of 0.25. Same is in NewPipe.
Why it displays on left if it's slower and on right if it's faster? It should stay in one place, moving elements are annoying for users.
I think more intuitive would be to remember last playback speed instead of a separate option in Settings. I'd assume that if I chose 2x in one video, it would be kept until I change it. That's how YouTube works, so that's what people are used to. |
app/src/main/res/values/strings.xml
Outdated
<string name="default_playback_speed_1">x0.25</string> | ||
<string name="default_playback_speed_2">x0.5</string> | ||
<string name="default_playback_speed_3">x0.75</string> | ||
<string name="default_playback_speed_4">x1.0</string> | ||
<string name="default_playback_speed_5">x1.25</string> | ||
<string name="default_playback_speed_6">x1.5</string> | ||
<string name="default_playback_speed_7">x1.75</string> | ||
<string name="default_playback_speed_8">x2.0</string> | ||
<string name="default_playback_speed_9">x3.0</string> | ||
<string name="default_playback_speed_10">x4.0</string> | ||
<string name="default_playback_speed_11">x5.0</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It shouldn't be in strings. Numeric value should be provided and formatted by the code according to current user region, not hard-coded. Check how it's done in Fossify Music Player.
- It should be
0.25x
,0.5x
etc.
Thanks for the review, it all does indeed makes sense, we'll fix all that ! |
Seems to work fine, thanks! Now please wait for the final review by Naveen 🙂 |
Just made some XML layout changes. Not too happy with the playback speed button placement but I don't have any ideas at the moment either so I guess I'll merge this now and improve it later. Thanks! |
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Before:
After:
Fixes the following issue(s)
Acknowledgement