Zoom branch

[RaJansuMan]

What is it?

• Bugfix
• Feature
• Codebase improvement

Description of the changes in your PR

• Changed Default Double tap zoom (3.0) to max of scaling factor based on width and height
• Added rotation to gestureImageView

Before/After Screenshots/Screen Record

• Before:

before.mp4

• After:

after.mp4

Fixes the following issue(s)

• Fixes webp images when double tapped don't zoom to height of image #363
• Fixes webp image did not rotate #410

Acknowledgement

• I read the contribution guidelines.

[naveensingh]

Thanks! Found two issues:

• It should be possible to rotate webp images using pinch-rotate gesture like how you can do with other formats.
• Rotating a landscape image works but the rotated preview doesn't fit bounds (example). Tapping the image fixes this.

Here's a test file: car.webp.remove.zip

[naveensingh]

Another issue that I could not reproduce again but observed on two devices:

Rotate image ➜ Wait for a few seconds ➜ Rotation is reverted automatically but the actual file is rotated without confirmation.

[RaJansuMan]

Zip file is damaged can you send it again.
Rotate image how should it behave, like when we rotate the image and exit photo fragment it saves the rotated image as written in onDestroy(). is that not intended feature?
What it should be?

[naveensingh]

Zip file is damaged can you send it again.

Just rename it to car.webp, it wasn't a zip file :)

is that not intended feature?

Yes, an intended behavior that is about to be changed. What I meant to say in this comment is that it happened automatically without any user input (back button was not pressed).

Since I can no longer reproduce it, you may focus your efforts on #412 (comment)

[RaJansuMan]

Pinch rotate gesture doesn't fit the image as library checks against setting less zoom.
Added a behaviour that if the image is zoomed rotating it manually doesn't reset the image to fit.
Instead of re-loading the image implemented rotation on already set image.
Tell me for any issues.