Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tribal ancient book revamped #392

Merged
merged 14 commits into from
Apr 8, 2024
Merged

Conversation

Fishpoker
Copy link
Contributor

@Fishpoker Fishpoker commented Feb 18, 2024

About The Pull Request

Replaces two usless granters whit one toxin immunity granter, one resiliance granter and a milk healer granter

Why It's Good For The Game

Two granters that fit tribals and get rid of the old usless ones and one additional one

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: Added new things
del: Removed old things
code: changed some code

/:cl:

@BrotherHangyul
Copy link
Contributor

roundstart night vision is stupid and shouldn't be given to tribals of all roles

@BurpleBineapple
Copy link
Contributor

Your tribals have trapper by default. See line 690 of code/modules/jobs/job_types/wasteland.dm:

ADD_TRAIT(H, TRAIT_TRIBAL, src) ADD_TRAIT(H, TRAIT_GENERIC, src) ADD_TRAIT(H, TRAIT_TRAPPER, src) ADD_TRAIT(H, TRAIT_MACHINE_SPIRITS, src) ADD_TRAIT(H, TRAIT_AUTO_DRAW, src)

@xTrainx xTrainx added the Balance this PR is aimed at balancing one or more aspect of the game label Mar 16, 2024
@xTrainx
Copy link
Contributor

xTrainx commented Mar 16, 2024

roundstart night vision is stupid and shouldn't be given to tribals of all roles

i think this is ok specifically because they are tribal, in lore, it makes sense since tribal hunters would need to be able to see better at night to hunt nocturnal game, and the limited gameplay paths they have are complimented by it, still it's better if we get more input about it

@xTrainx xTrainx added Changes Requested To label what has already been asked to be changed in a review Awaiting Input Code has been checked, waiting for other's input on the subject and removed Awaiting Input Code has been checked, waiting for other's input on the subject labels Mar 16, 2024
@Fishpoker
Copy link
Contributor Author

roundstart night vision is stupid and shouldn't be given to tribals of all roles

it isnt even full NV so no reason to bawl🥺🥺🥺

@BrotherHangyul
Copy link
Contributor

roundstart night vision is stupid and shouldn't be given to tribals of all roles

i think this is ok specifically because they are tribal, in lore, it makes sense since tribal hunters would need to be able to see better at night to hunt nocturnal game, and the limited gameplay paths they have are complimented by it, still it's better if we get more input about it

you realise that there's almost no mechanical limitations on tribals, right? they can still do things like use tech / guns / high-tier armour / etc. it's in the same vein as giving all legion roles roundstart night vision. they might be tribals in-lore, but there's nothing stopping them from acting like any old normal soldier in-game.

i am against powercreeping tribals further, they've been fed good enough as-is. we've already removed roundstart NVGs from factions like the BoS/Enclave (with only a few exceptions) for a reason.

@BigBigga
Copy link

hell nah bro theyre tryina powercreep tribals even harder. NV now????

@biotear
Copy link
Contributor

biotear commented Mar 24, 2024

roundstart night vision is stupid and shouldn't be given to tribals of all roles

i think this is ok specifically because they are tribal, in lore, it makes sense since tribal hunters would need to be able to see better at night to hunt nocturnal game, and the limited gameplay paths they have are complimented by it, still it's better if we get more input about it

Train, brother, I'm gonna be real with you here. As much as I'd love roundstart NV, this is a terrible idea. Now, the other two traits, I don't have much of an issue with. Roundstart night vision is a big no from me, however.

@Fishpoker
Copy link
Contributor Author

roundstart night vision is stupid and shouldn't be given to tribals of all roles

i think this is ok specifically because they are tribal, in lore, it makes sense since tribal hunters would need to be able to see better at night to hunt nocturnal game, and the limited gameplay paths they have are complimented by it, still it's better if we get more input about it

you realise that there's almost no mechanical limitations on tribals, right? they can still do things like use tech / guns / high-tier armour / etc. it's in the same vein as giving all legion roles roundstart night vision. they might be tribals in-lore, but there's nothing stopping them from acting like any old normal soldier in-game.

i am against powercreeping tribals further, they've been fed good enough as-is. we've already removed roundstart NVGs from factions like the BoS/Enclave (with only a few exceptions) for a reason.

its not full on NV relax

@CVSthePharmacy
Copy link

Checked, it's basically full NV in terms of how NV is like here. Not meson type, more so pilot goggles

@Fishpoker
Copy link
Contributor Author

Checked, it's basically full NV in terms of how NV is like here. Not meson type, more so pilot goggles

you wont be seeing anything but black past 4 tiles if its pitch dark like midnight or sewers

@xTrainx
Copy link
Contributor

xTrainx commented Mar 27, 2024

the requested changes have not been addressed yet, and i guess people would be against NV roundstart, even enclave got it denird, so thats a no go, change the loadout in 3 days or this PR will be closed

@Fishpoker
Copy link
Contributor Author

the requested changes have not been addressed yet, and i guess people would be against NV roundstart, even enclave got it denird, so thats a no go, change the loadout in 3 days or this PR will be closed

yh done

@xTrainx xTrainx removed the Changes Requested To label what has already been asked to be changed in a review label Mar 29, 2024
@xTrainx xTrainx added Awaiting Input Code has been checked, waiting for other's input on the subject Approved for Testmerge A reviewer has approved this to be testmerged. labels Mar 29, 2024
@xTrainx xTrainx merged commit dab4ae2 into Foundation-19:master Apr 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved for Testmerge A reviewer has approved this to be testmerged. Awaiting Input Code has been checked, waiting for other's input on the subject Balance this PR is aimed at balancing one or more aspect of the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants