Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs unified image #2143

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Update docs unified image #2143

merged 3 commits into from
Oct 7, 2024

Conversation

johscheuer
Copy link
Member

Description

Fixes: #1036.

Type of change

  • Documentation

Discussion

Images are pushed to: https://hub.docker.com/r/foundationdb/fdb-kubernetes-monitor

Testing

We already had some e2e tests for the unified image.

Documentation

Follow-up

@johscheuer johscheuer added the documentation Improvements or additions to documentation label Oct 7, 2024
@johscheuer johscheuer requested a review from nicmorales9 October 7, 2024 13:53
nicmorales9
nicmorales9 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@nicmorales9 nicmorales9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

README.md Outdated Show resolved Hide resolved
@johscheuer @nicmorales9
Update README.md
368cf11 
Co-authored-by: nicmorales9 <153320946+nicmorales9@users.noreply.github.com>
johscheuer
johscheuer commented Oct 7, 2024
View reviewed changes
Copy link
Member Author

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge the PR without waiting for CI as this PR only touches the docs.

@johscheuer johscheuer merged commit 45fe4cc into FoundationDB:main Oct 7, 2024
7 checks passed
@johscheuer johscheuer deleted the update-docs-unified-image branch October 7, 2024 16:10
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: f62d19a
  • Duration 2:50:30
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 368cf11
  • Duration 2:49:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicmorales9 nicmorales9 nicmorales9 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing warnings in docs about the unified image mode being experimental
3 participants
@johscheuer @foundationdb-ci @nicmorales9