Resolves #2993: AnalyzerChooser no longer takes the text when choosing an analyzer #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only implementation that actually referenced the text was in tests. This gets us on a path to an index having a fixed analyzer (at least for the duration of the transaction), which can simplify the FDBDirectoryWrapper. The premise for adding AnalyzerChooser was to use a different analyzer depending on the text to better support different languages, but this seems problematic, because you won't know when searching what analyzer was used. i.e. if you have a document that is mixed, and then search only for one language, it will be confused. Instead a more complicated analyzer should be used to support this, if needed.
Since there is no longer a text parameter, it can generater the wrappers once. This may result in some wasted CPU generating unused analyzers (e.g. when not querying or not writing), but it should be compensated by the fact that it consistently creates 2 wrappers, rather than creating a wrapper for every record update, or every query.
Only initialize this once, and reuse. Part of the process of making FDBDirectoryWrapper not have to worry about changing analyzers
Result of fdb-record-layer-pr on Linux CentOS 7
|
Result of fdb-record-layer-pr on Linux CentOS 7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves it so that the DirectoryManager creates one
LuceneAnalyzerWrapper, and preserves it for the transaction.It also means that
FDBDirectoryWrapperhas a singlewriterthat won't change, making it lazy, but final.