Add/amazon order route #1492
Merged
Add/amazon order route #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diokuz
force-pushed
the
add/amazon-order-route
branch
from
e611ee3 to
1428b1a
Compare
tonypizzicato
suggested changes
Apr 18, 2017
ashes/src/modules/orders/details.js
Outdated
| @@ -18,6 +18,11 @@ const _getOrder = createAsyncActions( | |||
| (refNum: string) => Api.get(`/orders/${refNum}`) | |||
| ); | |||
|
|
|||
| const _getAmazonOrder = createAsyncActions( | |||
| 'getAmazonOrder', | |||
| (refNum: string) => Api.get(`/hyperion/orders/111-5296499-9653858/full`) // ${refNum} | |||
ashes/src/modules/orders/details.js
Outdated
| export const updateOrder = _updateOrder.perform; | ||
| export const updateShipments = _updateShipments.perform; | ||
| export const clearFetchErrors =_getOrder.clearErrors; | ||
|
|
||
| function orderSucceeded(state: State, payload: Object): State { | ||
| const order: OrderParagon = new OrderParagon(payload.result || payload); | ||
| const res = payload.result || payload; |
There was a problem hiding this comment.
i think this condition can be deleted
|
and i think we should add a link to |
| @@ -77,19 +80,29 @@ const setCellContents = (order, field) => { | |||
| } | |||
| }; | |||
|
|
|||
| type Props = { | |||
| order: OrderParagon; | |||
| columns: Array<*>; | |||
There was a problem hiding this comment.
we have Columns in interface/table.js
tonypizzicato
approved these changes
Apr 18, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design
What was done
[Invalid]text with value as a fallback in State component.What is not done here