Fix highlander builds #21
Conversation
| BUILDDIRS = $(SUBDIRS:%=build-%) build-integrations | ||
| TESTDIRS = $(SUBDIRS:%=test-%) test-integrations | ||
| BUILDDIRS = $(SUBDIRS:%=build-%) | ||
| TESTDIRS = $(SUBDIRS:%=test-%) |
There was a problem hiding this comment.
Not sure about this, need more feedback about how it works
There was a problem hiding this comment.
@jmataya Gonna move integration/shipstation to level up and treat it as equal project
There was a problem hiding this comment.
... maybe later, this PR is growing exponentially
pavel-main
force-pushed
the
fix/there-can-be-only-one
branch
from
3db67af to
8dedbca
Compare
pavel-main
force-pushed
the
fix/there-can-be-only-one
branch
from
abd8f5d to
39c63b8
Compare
| ln -s `pwd` $(BUILDPATH); true | ||
| rm -rf $(GOPATH)/src/github.com/FoxComm/highlander | ||
| mkdir -p $(GOPATH)/src/github.com/FoxComm/highlander | ||
| cp -R . $(BUILDPATH) |
There was a problem hiding this comment.
go build works with symlinking, but I had troubles with go test, this is the clunky solution I came to
There was a problem hiding this comment.
Yeah, I've noticed the go test problems recently. This seems like as good of a solution as I had.
pavel-main
force-pushed
the
fix/there-can-be-only-one
branch
from
0f80a4f to
b7f9d4e
Compare
Set BuildKite project for Highlander
| @@ -16,8 +16,7 @@ import: | |||
| version: 0c8185d9a3ba82aeac98db3313a268a5b6df99b5 | |||
| - package: github.com/elodina/go-kafka-avro | |||
| vcs: git | |||
| version: 0c29ad915b6b7dc6cf416005fdae3d1c6b5d9672 | |||
| repo: git@github.com:FoxComm/go-kafka-avro.git | |||
| version: ab6b1d1c9a2361e639af25c13653fee505b5d2ce | |||
There was a problem hiding this comment.
You want to revert this change. We need the FoxComm-specific go-kafka-avro because it fixes a bug in the upstream library. See: elodina/go-kafka-avro#9.
If glide install fails with an error once you've reverted the change, blow away /vendor and all will be good.
|
In general, it looks good. Make sure to check out the comments on middlewarehouse before we merge. |
pavel-main
force-pushed
the
fix/there-can-be-only-one
branch
from
cd81184 to
01a33b7
Compare
pavel-main
force-pushed
the
fix/there-can-be-only-one
branch
from
df38a9c to
1677d55
Compare
pavel-main
force-pushed
the
fix/there-can-be-only-one
branch
from
f01cd4a to
df0a6c5
Compare
PROJECTS=(ashes firebrand fox-notifications green-river integration-tests isaac middlewarehouse phoenix-scala prov-shit)TODO:
prodsmallprojectflywayinprov-shitchownbuildkite agent's home directoryfirebirdproject