Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log activity in RemorseActor #494

Merged
merged 12 commits into from
Nov 29, 2016
Merged

Conversation

pavel-main
Copy link
Contributor

@pavel-main pavel-main commented Nov 28, 2016

Changes required in:

  • Phoenix (log activity in RemorseActor)
  • Consumers (handle additional activity type and request Phoenix for additional info)
    • Gift Cards
    • Shipstation
    • Shipments
  • Provisioning (set Phoenix environment variables for consumers)


class RemorseTimer(implicit db: DB, ec: EC) extends Actor {
implicit val ac =
ActivityContext(userId = 1, userType = "admin", transactionId = letterify("?" * 5))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this a def on ActivityContext object?

Copy link
Contributor

@nautiluz92 nautiluz92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GC consumer LGTM

@pavel-main pavel-main merged commit 22d10e1 into master Nov 29, 2016
@pavel-main pavel-main deleted the fix/update-activity-in-remorse-actor branch November 29, 2016 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants