Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order line item GC info #498

Merged
merged 23 commits into from
Dec 8, 2016
Merged

Order line item GC info #498

merged 23 commits into from
Dec 8, 2016

Conversation

nautiluz92
Copy link
Contributor

@nautiluz92 nautiluz92 commented Nov 29, 2016

No description provided.

@nautiluz92 nautiluz92 added the WIP label Nov 29, 2016
@tonypizzicato tonypizzicato force-pushed the middelwarehouse/update-oli-gc-code branch from f3ff7ce to adc1d3e Compare November 30, 2016 23:26
@tonypizzicato tonypizzicato self-assigned this Dec 1, 2016
@tonypizzicato tonypizzicato force-pushed the middelwarehouse/update-oli-gc-code branch from adc1d3e to b6dc500 Compare December 2, 2016 15:54
@tonypizzicato tonypizzicato changed the title update order line items with GC code [WIP] Cart/order line item GC info Dec 2, 2016
@tonypizzicato tonypizzicato changed the title Cart/order line item GC info Order line item GC info Dec 2, 2016
@tonypizzicato tonypizzicato force-pushed the middelwarehouse/update-oli-gc-code branch from 36d4b6c to a4f30d4 Compare December 2, 2016 17:25
@tonypizzicato
Copy link
Contributor

Copy link
Contributor

@jmataya jmataya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reeeeeeally small change

clientID = "gift-cards"
groupID = "mwh-gift-cards-consumers"
clientID = "gift-cards-tony"
groupID = "mwh-gift-cards-consumers-tony"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind pulling the tony off? :)

@@ -43,8 +43,7 @@ type Order struct {
TagIDs []int `json:"tagIds"`
}

func NewOrderFromPhoenix(order phoenix.Order) (*Order, error) {

func NewOrderFromActivity(order mwhPayloads.Order) (*Order, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tonypizzicato tonypizzicato force-pushed the middelwarehouse/update-oli-gc-code branch from 489fed9 to ebecd41 Compare December 7, 2016 19:54
@jmataya jmataya merged commit 8ef77ff into master Dec 8, 2016
@jmataya jmataya deleted the middelwarehouse/update-oli-gc-code branch December 8, 2016 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants