Removes Dummy Features from Ashes #553
Conversation
ghost
added
| // <a className="fc-watchers__link" onClick={e => this.watch(e, groups.assignees)}>take it</a> | ||
| // </div> | ||
| // </div> | ||
| // {renderGroup(props, groups.assignees)} |
There was a problem hiding this comment.
^ Should we just ehm... remove this lines?
There was a problem hiding this comment.
Agree with Pavel's comment.
There was a problem hiding this comment.
My thought here was that the feature actually works. Just right now there's no difference between "Assignees" and "Watchers". We need to think through this story and add it back once we figure out what to do with Assignees. @jmataya Would you still prefer me to remove it at this point?
| "metaTitle", | ||
| "metaDescription" | ||
| ] | ||
| } |
There was a problem hiding this comment.
We should definitely remove URL, but should we just implement meta title and meta description in Firebrand, TPG, and TD?
There was a problem hiding this comment.
@jmataya Right now this isn't implemented anywhere. From the API documentation I don't think it's in the API either for a product detail which is why I removed it. Am I wrong? If it's at least in the API, then I'll add it back in, but right now this section does nothing
There was a problem hiding this comment.
URL is renamed into Slug in #505
I agree: probably, we should finish SEO section integration in storefronts instead of deleting it completely from ashes.
There was a problem hiding this comment.
There was a problem hiding this comment.
I'm fine with that. Let's prioritize making Ashes usable.
| // <a className="fc-watchers__link" onClick={e => this.watch(e, groups.assignees)}>take it</a> | ||
| // </div> | ||
| // </div> | ||
| // {renderGroup(props, groups.assignees)} |
There was a problem hiding this comment.
Agree with Pavel's comment.
| "metaTitle", | ||
| "metaDescription" | ||
| ] | ||
| } |
There was a problem hiding this comment.
@jmataya Right now this isn't implemented anywhere. From the API documentation I don't think it's in the API either for a product detail which is why I removed it. Am I wrong? If it's at least in the API, then I'll add it back in, but right now this section does nothing
|
Re-running tests to see if we can get them to pass. |
ghost
dismissed
jmataya’s stale review
Discussed above - Removed layout.json changes since they are already coming in another PR
Removes:
-Email & Notifications Preferences from Customer Details
-SEO section from Product Details
-Assignees field from Assignees/Watchers (since Assignees/Watchers do the same thing)