Return createdAt value for credit card in cart responses.
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annappropriate
suggested changes
Dec 14, 2016
| @@ -18,6 +18,18 @@ import utils.aliases._ | |||
| import utils.aliases.stripe._ | |||
| import utils.db._ | |||
|
|
|||
| case class CreditCardAddress( | |||
There was a problem hiding this comment.
Please rename to BillingAddress
vkorbut
force-pushed
the
bugfix/credit-cart-created-at
branch
from
bd0cc0c to
7d7f47d
Compare
annappropriate
approved these changes
Dec 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds
CreditCard.createdAtfield.But CreditCard becomes class with 23 fields and therefore it cannot be used in slick (scala supports max 22 fields in tuple)
So address related fields were moved to a separate
CreditCardAddressclass.Fixes https://app.yodiz.com/plan/pages/scrum-board.vz?cid=31946&pid=3&iid=3#/app/bg-15