References was not participated in filtering at checkBuckets #618
+79
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have 2 tradeoffs here: 1) Filter results in scala 2) Inject es filter to rawQuery fetched from postgres I have choosed second one because for big amount of products result can be big, instead of references which almost small list of ids. Also return pureResult if references is empty without interaction with ES
|
I don't know all of this code super well, but it seems good to me. Since the break in build was due to our trusty timeouts, I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 2 tradeoffs here:
I have choosed second one because for big amount of products
result can be big, instead of references which almost small list of ids.
Also return pureResult if references is empty without interaction with ES