Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Stripe's address and zip check fields from credit card #651

Merged
merged 1 commit into from
Jan 3, 2017

Conversation

annappropriate
Copy link
Contributor

@annappropriate annappropriate commented Jan 3, 2017

These two fields are a part of Stripe's response — even if we might want to analyse their values, there's no point in storing them

Copy link
Contributor

@michalrus michalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michalrus michalrus merged commit 46c12b2 into master Jan 3, 2017
@ghost ghost added the ready to review label Jan 3, 2017
@michalrus michalrus deleted the chores/cc-remove-address-and-zip-checks branch January 3, 2017 14:57
narma pushed a commit that referenced this pull request Jan 4, 2017
…roducts-taxonomies-and-kangaroos

* 'master' of github.com:FoxComm/highlander: (21 commits)
  Call sbt only once in Makefile test
  Fix triggered SBT tasks by moving version write to assembly
  Remove Stripe's address and zip check fields from credit card (#651)
  Test terraform formatting script
  Canonical terraform formatting
  Use transactionally method for big seeds
  Use plainText "hash" algorithm for passwords in tests
  Fix get new id from coupon response
  Add migration shortcuts
  Delete Dockerfile.capture-consumer
  Create Dockerfile.capture-consumer
  Add error msg on bad sku
  Turn slug to lowercase on product insert/update.
  Correct some grammar in the_fox_system.tex
  Fix typos in object_model.tex
  References was not participated in filtering at checkBuckets
  Prevent indexing document to non-existing index
  Introducing of CordPaymentState enum for `Order.paymentState` field
  Rename InternalPaymentAdjustment -> PaymentAdjustment
  Naming fixes
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants