Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit conversion short * to char * with adding null terminator #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add explicit conversion short * to char * with adding null terminator #12

wants to merge 1 commit into from

Conversation

Kristiks00
Copy link

@Kristiks00 Kristiks00 commented Dec 3, 2024 •
edited
Loading

In function ngx_sll_ja4 c->ssl->ciphers and c->ssl->extensions are used like char *, but their type is unsigned short *. So we get Segmentation fault signal from strlen.Explicit conversion and adding null terminator solve this problem.

Close issue #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kristiks00