Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JA4 is including signature hash algorithms outside of the signature hash extension #41

Closed
john-althouse opened this issue Jan 2, 2024 · 0 comments
Closed

JA4 is including signature hash algorithms outside of the signature hash extension #41

john-althouse opened this issue Jan 2, 2024 · 0 comments
Assignees
@igr001-galactica
Labels
bug Something isn't working

Comments

@john-althouse
Copy link
Collaborator

If a TLS Client Hello contains the "Delegated Credentials" extension, for example, JA4 will include those Signature Hash Algorithms in JA4_c when it should only include the Signature Hash Algorithms from the "Signature Algorithms" extension.
@john-althouse john-althouse added the bug Something isn't working label Jan 2, 2024
vvv added a commit to vvv/ja4 that referenced this issue Jan 4, 2024
@vvv
JA4: Take sig_hash_alg values from signature_algorithms extension…
274cfcc 
… only

Related issue: FoxIO-LLC#41
@vvv vvv mentioned this issue Jan 4, 2024
Merged
noeltimothy added a commit to noeltimothy/ja4 that referenced this issue Jan 4, 2024
@noeltimothy
fixes FoxIO-LLC#41
dd1b64b
@noeltimothy noeltimothy mentioned this issue Jan 4, 2024
Merged
igr001-galactica pushed a commit that referenced this issue Jan 4, 2024
@vvv
Rust implementation fixes (#45)
fe853f6 
* JA4: Include SNI and ALPN in the "original" outputs

Include SNI (0000) and ALPN (0010) in `ja4_o` and `ja4_ro` output.

Context: #40 (comment)

* JA4H: Ignore case when searching for "Cookie" and "Referer" fields

* JA4: Take `sig_hash_alg` values from `signature_algorithms` extension only

Related issue: #41

* Update Rust dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igr001-galactica igr001-galactica

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igr001-galactica @john-althouse