-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for owner password #37
Conversation
novag
commented
Jan 28, 2024
- Allow specifying an owner password when creating the SRK
Thanks for the very quick review! Unfortunately, I've only now found the time to address the review. |
Still missing a test to check that |
Thanks! I will push the test soon. However, this PR is blocked until google/go-tpm#357 is merged. |
Currently away so won't review this until later this weeks, but why do you need HierarchyChangeAuth for this change? |
It's required to set an initial owner password for the test. Or is there another way that I am not aware of to initialize the TPM simulator with an owner password? |
Ah, this makes sense :) I haven't read the complete TPM spec and stuff I do is very much me learning as a I go. I haven't messed around with owner password so you are probably correct. |
I haven't read the whole spec either, but I'm pretty sure there's no other command for it. Thanks for your quick reply! :) |
Please do tell me if the |
* Allow specifying an owner password when creating the SRK
LGTM. Thanks for working on this :) |