ssh-tpm-keygen: set default number of bits for ecdsa and rsa #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stigtsp
force-pushed
the
keygen-set-default-num-bits
branch
from
3d9e2ab to
1b96a2d
Compare
When calling ssh-tpm-agent without `-b` the number of bits defaults to 0, leading to: invalid ecdsa key length: TPM does not support 0 bits This sets the default number of bits to 256 for ecdsa and or 2048 for rsa.
stigtsp
force-pushed
the
keygen-set-default-num-bits
branch
from
1b96a2d to
0757edd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling ssh-tpm-agent without
-bthe number of bits defaults to 0, leading to:This sets the default number of bits to 256 for ecdsa and or 2048 for rsa.
Closes #42