Regex fix for compilation errors with DATA #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to the regular expression used for parsing compilation errors from perl -c. When a compilation error occurs after a imported module that has used the DATA section, the context of DATA is included. For example, when compile checking the following short file:
gives the following error
Global symbol "$foo" requires explicit package name (did you forget to declare "my $foo"?) at /tmp/testing.pl line 3, <DATA> line 197.
PLS will run the regex on this, and then discard the error because the result of the 2nd capture group:
/tmp/testing.pl line 3, <DATA>
does not match the originally requested filename.Looks like Perl::LanguageServer includes this capture group modifier as well: https://github.com/richterger/Perl-LanguageServer/blob/f4bd1f39630cb2c490c2f82d0e5e9bc8b410e8da/lib/Perl/LanguageServer/SyntaxChecker.pm#L263