Add new graphical representations to LanguageModel #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VicenteAR <vicente.arjona@hotmail.com>
Signed-off-by: VicenteAR <vicente.arjona@hotmail.com>
Signed-off-by: VicenteAR <vicente.arjona@hotmail.com>
Signed-off-by: VicenteAR <vicente.arjona@hotmail.com>
|
Fixed problems:
================================================================== |
Guillemdb
requested changes
May 9, 2021
language_competition/models.py
Outdated
| @@ -1,14 +1,21 @@ | |||
| """Module containing custom classes to study different language competition models.""" | |||
| from typing import Optional, Tuple, Union | |||
|
|
|||
| from bokeh.models import FixedTicker | |||
| import holoviews as hv | |||
| from holoviews import opts | |||
| import matplotlib as mpl | |||
There was a problem hiding this comment.
Suggested change
| import matplotlib as mpl |
language_competition/models.py
Outdated
| @@ -1,14 +1,21 @@ | |||
| """Module containing custom classes to study different language competition models.""" | |||
| from typing import Optional, Tuple, Union | |||
|
|
|||
| from bokeh.models import FixedTicker | |||
| import holoviews as hv | |||
| from holoviews import opts | |||
| import matplotlib as mpl | |||
| import matplotlib.pyplot as plt | |||
There was a problem hiding this comment.
Suggested change
| import matplotlib.pyplot as plt |
Guillemdb
reviewed
May 9, 2021
| import matplotlib as mpl | ||
| import matplotlib.pyplot as plt | ||
| import numpy as np | ||
| import panel as pn | ||
|
|
There was a problem hiding this comment.
Suggested change
| from IPython.core.display import display | |
Signed-off-by: VicenteAR <vicente.arjona@hotmail.com>
VicenteAR
changed the title
|
Fixed problems. Removed matplotlib libraries. Changed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new methods to represent the lattice (using holoviews). A few problems are in order:
_plot()insiderunis not properly called (plot is not returned)Signed-off-by: VicenteAR vicente.arjona@hotmail.com