Skip to content

hx20: CHARGE_LIMIT_CONTROL min_percentage is unused #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DHowett opened this issue Jan 21, 2022 · 1 comment
Open

hx20: CHARGE_LIMIT_CONTROL min_percentage is unused #1

DHowett opened this issue Jan 21, 2022 · 1 comment

Comments

@DHowett
Copy link
Contributor

DHowett commented Jan 21, 2022

Filing this as a feature request!

It looks like you planned on having a configurable min percentage for the charge limit, presumably to allow the battery to fall to a certain percentage before resuming charging.
@DHowett DHowett changed the title EC_CMD_CHARGE_LIMIT_CONTROL min_percentage is unused CMD_CHARGE_LIMIT_CONTROL min_percentage is unused Jan 23, 2022
@DHowett DHowett changed the title CMD_CHARGE_LIMIT_CONTROL min_percentage is unused CHARGE_LIMIT_CONTROL min_percentage is unused Jan 23, 2022
@DHowett DHowett changed the title CHARGE_LIMIT_CONTROL min_percentage is unused hx20: CHARGE_LIMIT_CONTROL min_percentage is unused Jun 10, 2022
@Anachron
Copy link

This would certainly be useful! Has anybody started working on this?

@Benjamin-Loison Benjamin-Loison mentioned this issue Sep 3, 2024
Open
@AkechiShiro AkechiShiro mentioned this issue Oct 22, 2024
Open
kiram9 pushed a commit that referenced this issue Apr 15, 2025
@LeoCX-Tsai @quinchou77
fwk: avoid reset timer trigger clear charger limit
c25dec4 
when AC drop will trigger extender reset timer
and if timer times end will set back the charger mode to normal
but if charger limit is active we should keep the status.

BRANCH=fwk-main
BUG=https://app.clickup.com/t/86et2u0ve (#1)
TEST= test on azalea, setting charger limit to 80% and batt extender reset time to 1 min
into S0, plug-out AC wait 2min than plug-in AC, check charger mode still discharge or Idle

Signed-off-by: LeoCX_Tsai <LeoCX_Tsai@compal.com>
(cherry picked from commit 1d228d5020aa81c074d8c45b55d0ac1eb48bca39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DHowett @Anachron